implements CurrentUserPrivilegeSet to add compatibility with thunderb…

[mheers]

…ird address book

[oliverpool]

I just got the exact same issue myself and solved it before seeing your PR 🙈

[oliverpool]

In my case, I got it to work with Thunderbird locally with the following structure (didn't tried yours TBH):

Suggested change

	Privileges []Privilege `xml:"privilege"`
	}
	type Privilege struct {
	Read bool `xml:"read"`
	Write bool `xml:"write"`
	}
	Privileges []Privilege `xml:"privilege>dynamic"`
	}
	type Privilege struct {
	XMLName xml.Name
	}

And then return read, write like this:

return &internal.CurrentUserPrivilegeSet{Privileges: []internal.Privilege{{XMLName: xml.Name{"", "read"}}, {XMLName: xml.Name{"", "write"}}}}, nil

(ideally the read/write privileges information should come from the backend)

[emersion]

Seems like the second part of the suggestion hasn't been applied. (But I prefer the struct approach.)

[oliverpool]

Reference: https://stackoverflow.com/a/57124617/3207406

[emersion]

Nit: this file use the same name as the XML element even if there may be multiple.

[emersion]

Why dynamic? This doesn't appear in the RFC AFAIK.

[emersion]

Instead of a list, could we use a struct with fields for read/write?

[oliverpool]

FYI my PR is ready for review: #172 (supports user-defined ReadOnly)