-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Embroider #53
base: master
Are you sure you want to change the base?
Conversation
❌ Deploy Preview for field-guide failed.
|
@mansona embroider-optimized is still failing, as are the latest versions of Ember |
@elwayman02 yea sorry I'm kinda in-progress on a lot of things with this 😂 This is the next step to try and get ember-learn/ember-styleguide#422 to work with embroider optimised and we will likely need to adjust some things making use of ember-cli/ember-try#850 too 👍 Also this is only cleaning up CI to try to keep PRs as only one logical change, the "solution" to Embroider Optomised is #58 👍 |
Oh and the netlify build is failing because fastboot doesn't work with embroider correctly for one of the macros we're using: embroider-build/embroider#1203 |
Ack. I only mention it cuz you marked it ready for review. :P |
bcac4fb
to
9b722b8
Compare
@mansona this will need some rebasing after I started landing blueprint updates |
@mansona any chance we can get this updated and landed? Addons using field-guide for their docs can't get clean embroider builds even if their actual addon code is embroider-compat, due to field-guide itself failing. |
f488528
to
17a170f
Compare
No description provided.