Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Embroider #53

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Support Embroider #53

wants to merge 7 commits into from

Conversation

mansona
Copy link
Member

@mansona mansona commented Dec 29, 2021

No description provided.

@netlify
Copy link

netlify bot commented Dec 29, 2021

Deploy Preview for field-guide failed.

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/field-guide/deploys/66b24d324c76d61398b4c364

@mansona mansona marked this pull request as ready for review May 16, 2022 16:49
@elwayman02
Copy link
Contributor

@mansona embroider-optimized is still failing, as are the latest versions of Ember

@mansona
Copy link
Member Author

mansona commented May 18, 2022

@elwayman02 yea sorry I'm kinda in-progress on a lot of things with this 😂 This is the next step to try and get ember-learn/ember-styleguide#422 to work with embroider optimised and we will likely need to adjust some things making use of ember-cli/ember-try#850 too 👍

Also this is only cleaning up CI to try to keep PRs as only one logical change, the "solution" to Embroider Optomised is #58 👍

@mansona
Copy link
Member Author

mansona commented May 18, 2022

Oh and the netlify build is failing because fastboot doesn't work with embroider correctly for one of the macros we're using: embroider-build/embroider#1203

@elwayman02
Copy link
Contributor

@elwayman02 yea sorry I'm kinda in-progress on a lot of things with this 😂 This is the next step to try and get ember-learn/ember-styleguide#422 to work with embroider optimised and we will likely need to adjust some things making use of ember-cli/ember-try#850 too 👍

Also this is only cleaning up CI to try to keep PRs as only one logical change, the "solution" to Embroider Optomised is #58 👍

Ack. I only mention it cuz you marked it ready for review. :P

@elwayman02
Copy link
Contributor

@mansona this will need some rebasing after I started landing blueprint updates

@elwayman02 elwayman02 added enhancement New feature or request help wanted dependencies Pull requests that update a dependency file labels Feb 15, 2023
@elwayman02
Copy link
Contributor

@mansona any chance we can get this updated and landed? Addons using field-guide for their docs can't get clean embroider builds even if their actual addon code is embroider-compat, due to field-guide itself failing.

@mansona mansona added good first issue Good for newcomers and removed help wanted labels Jul 26, 2024
@mansona mansona force-pushed the embroider branch 4 times, most recently from f488528 to 17a170f Compare July 26, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants