use configured title as alt attribute of logo image

[jelhan]

No description provided.

[mansona]

Hey thanks for the contribution @jelhan 👍

I'm wondering if this is an appropriate change 🤔 I'm wondering if you should have any title on the image at all? or should we make it presentation only?

What do you think?

[jelhan]

I'm wondering if this is an appropriate change thinking I'm wondering if you should have any title on the image at all? or should we make it presentation only?

The title is not rendered at all if the blog has a logo.

guidemaker-default-template/app/templates/application.hbs

Lines 7 to 13 in 4345c17

	{{#if guidemaker.logo}}
	<img src={{guidemaker.logo}}>
	{{else}}
	<span>
	{{guidemaker.title}}
	</span>
	{{/if}}

Therefore I would not consider the logo as presentation only. The logo is the only thing which tells the user what the guide is about. For people using assistive technologies that information would not be available unless the alt attribute is set. So actually I think it's an accessibility question. If I recall correctly, a failing a11y test or linting rule was motivating this pull request.

[mansona]

hey are you still interested in looking at this?