Provide a way to reject Promise in instantiateWasm #23780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't change behaviour, just fixes a typo
sbc100
reviewed
Feb 27, 2025
Collaborator
sbc100
left a comment
sbc100
left a comment
There was a problem hiding this comment.
lgtm!
Can we get a test for it though. See test_instantiate_wasm in test_other.py
Contributor
Author
|
Sorry I didn't manage to run the test suite locally so I have no idea if my test succeeds. I don't have a lot of time to sink into this :/ Also this PR is changing how those tests work so I probably should wait for it. |
sbc100
approved these changes
Mar 5, 2025
sbc100
reviewed
Mar 5, 2025
Collaborator
sbc100
left a comment
sbc100
left a comment
There was a problem hiding this comment.
Hmm, test failures look valid, but I can't see why this change would break stuff
|
|
||
| .. js:function:: Module.instantiateWasm | ||
|
|
||
| When targeting WebAssembly, Module.instantiateWasm is an optional user-implemented callback function that the Emscripten runtime calls to perform the WebAssembly instantiation action. The callback function will be called with two parameters, ``imports`` and ``successCallback``. ``imports`` is a JS object which contains all the function imports that need to be passed to the WebAssembly Module when instantiating, and once instantiated, this callback function should call ``successCallback()`` with the generated WebAssembly Instance object. |
Collaborator
There was a problem hiding this comment.
Can we put Module.instantiateWasm in double backticks here?
Also, can you wrap these lines at 80 columns?
sbc100
reviewed
Mar 5, 2025
| receiveInstance(mod, inst); | ||
| Module['instantiateWasm'](info, (inst, mod) => { | ||
| receiveInstance(inst, mod); | ||
| resolve(mod.exports); |
Collaborator
There was a problem hiding this comment.
Ah, this needs to be inst.exports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix a typo in parameters name introduced by ec40bc5
Fixes: #23038