Remove unused JS library function: jstoi_s. NFC#23788
Closed
sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
Closed
Remove unused JS library function: jstoi_s. NFC#23788sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
jstoi_s. NFC#23788sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
Conversation
This function was also mis-documented. Its was added emscripten-core#10457 but even then it was unused only add because "good to have for completeness". However, the behavior of the JS `Number` function is not as described in the comment. Instead `Number("123abc")` returns NaN. On balance I think its better to just remove it.
Collaborator
Author
|
Closing a favor of larger change #23789 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function was also mis-documented. Its was added #10457 but even then it was unused only add because "good to have for completeness".
However, the behavior of the JS
Numberfunction is not as described in the comment. InsteadNumber("123abc")returns NaN.On balance I think its better to just remove it.