Remove no-longer-needed jstoi_q helper function. NFC #23790
Closed
+36
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like radix parameter is now optional in closure compiler: |
Less risky version emscripten-core#23789. It seems that the original issue we had with closure compile is no longer a problem and we can simply use parseInt with a single argument now. See google/closure-compiler#3230
sbc100
force-pushed
the
remove_jstoi_q
branch
from
c179e13 to
9964f4f
Compare
kripken
approved these changes
Feb 28, 2025
|
Oops, I misinterpreted the closure defintion.. this is still causing warnings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Less risky version #23789. It seems that the original issue we had with closure compile is no longer a problem and we can simply use parseInt with a single argument now.
See #10457 and google/closure-compiler#3230