[embind] Initialize embind on wasm workers. #24191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendandahl
force-pushed
the
embind-wasm-workers
branch
from
72ad89f to
ab2ef9f
Compare
sbc100
reviewed
Apr 27, 2025
tools/link.py
Outdated
| @@ -1405,6 +1405,8 @@ def limit_incoming_module_api(): | |||
|
|
|||
| if settings.WASM_WORKERS: | |||
| settings.DEFAULT_LIBRARY_FUNCS_TO_INCLUDE += ['$_wasmWorkerInitializeRuntime'] | |||
| if settings.EMBIND: | |||
| settings.REQUIRED_EXPORTS.append('_embind_initialize_bindings') | |||
There was a problem hiding this comment.
These two lines are duplicated in setup_pthreads.
How about moving them to the if EMBIND section on line 1383?
kripken
approved these changes
Apr 28, 2025
sbc100
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24189