Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building with bitwuzla>=0.4.0 due to breaking API changes #604

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thotypous
Copy link

After installing Bitwuzla, HAL fails to build with:

/hal-emsec/src/netlist/boolean_function/solver.cpp: In function ‘hal::Result<std::tuple<bool, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > hal::SMT::Bitwuzla::query_library(const std::string&, const hal::SMT::QueryConfig&)’:
/hal-emsec/src/netlist/boolean_function/solver.cpp:259:107: error: no matching function for call to ‘bitwuzla::parser::Parser::Parser(bitwuzla::Options&, const char [13], _IO_FILE*&, const char [5], std::ostream*)’
  259 |                 bitwuzla::parser::Parser parser(options, "VIRTUAL_FILE", in_stream, "smt2", &output_stream);
      |                                                                                                           ^
In file included from /hal-emsec/src/netlist/boolean_function/solver.cpp:12:
/usr/include/bitwuzla/cpp/parser.h:65:3: note: candidate: ‘bitwuzla::parser::Parser::Parser(bitwuzla::TermManager&, bitwuzla::Options&, const std::string&, std::ostream*)’
   65 |   Parser(TermManager &tm,
      |   ^~~~~~
/usr/include/bitwuzla/cpp/parser.h:65:3: note:   candidate expects 4 arguments, 5 provided
/hal-emsec/src/netlist/boolean_function/solver.cpp:261:51: error: no matching function for call to ‘bitwuzla::parser::Parser::parse(bool)’
  261 |                 std::string err_msg = parser.parse(false);
      |                                       ~~~~~~~~~~~~^~~~~~~
/usr/include/bitwuzla/cpp/parser.h:98:8: note: candidate: ‘void bitwuzla::parser::Parser::parse(const std::string&, bool, bool)’
   98 |   void parse(const std::string &input,
      |        ^~~~~
/usr/include/bitwuzla/cpp/parser.h:98:33: note:   no known conversion for argument 1 from ‘bool’ to ‘const std::string&’ {aka ‘const std::__cxx11::basic_string<char>&’}
   98 |   void parse(const std::string &input,
      |              ~~~~~~~~~~~~~~~~~~~^~~~~
/usr/include/bitwuzla/cpp/parser.h:114:8: note: candidate: ‘void bitwuzla::parser::Parser::parse(const std::string&, std::istream&, bool)’
  114 |   void parse(const std::string &infile_name,
      |        ^~~~~
/usr/include/bitwuzla/cpp/parser.h:114:8: note:   candidate expects 3 arguments, 1 provided
/hal-emsec/src/netlist/boolean_function/solver.cpp: In function ‘hal::Result<std::tuple<bool, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > hal::SMT::Bitwuzla::query_binary(const std::string&, const hal::SMT::QueryConfig&)’:
/hal-emsec/src/netlist/boolean_function/solver.cpp:289:83: warning: unused parameter ‘input’ [-Wunused-parameter]
  289 |             Result<std::tuple<bool, std::string>> query_binary(const std::string& input, const QueryConfig& config)
      |                                                                ~~~~~~~~~~~~~~~~~~~^~~~~
ninja: build stopped: subcommand failed.

This is due to breaking API changes introduced by Bitwuzla version 0.4.0: https://github.com/bitwuzla/bitwuzla/blob/main/NEWS.md#news-for-version-040. Bitwuzla is currently at version 0.7.0.

@thotypous thotypous requested a review from SJulianS as a code owner February 6, 2025 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant