Add const to new_unchecked()
#28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@npmccallum or @rvolosatovs Can the minimal version of Rust be incremented to a point where this can be used? |
|
@CuriouslyCurious Looks good to me, but could you re-write the commit message so it's a conventional commit? It'll allow the last test to pass. Something like |
Signed-off-by: CuriouslyCurious <[email protected]>
auto-merge was automatically disabled
August 25, 2023 22:29
Head branch was pushed to by a user without write access
CuriouslyCurious
force-pushed
the
const
branch
from
94e8368
to
222f953
Compare
Fixed it. ^^ |
rjzak
approved these changes
Aug 26, 2023
|
Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a need to have a
FlagSetin a compile-time constant, which wasn't possible before, so I simply addedconsttonew_unchecked.I didn't add
constto the othernew_*functions due to theFlag::Typecallingdefault()which is not yet possible in aconstcontext.While it is unfortunate that you have to have an unsafe block to have a
FlagSetin a constant, it is however better than it not being possible at all. :P