Include choices params even for non editable fields#9929
Open
ticosax wants to merge 1 commit intoencode:mainfrom
Open
Include choices params even for non editable fields#9929ticosax wants to merge 1 commit intoencode:mainfrom
ticosax wants to merge 1 commit intoencode:mainfrom
Conversation
31c8854 to
758b6ec
Compare
The choices param can be usefull to populate list of possible values and to instantiate a ChoiceField on the serializer, even when field is non_editable. Relevant for the live doc and the OpenAPI integration.
758b6ec to
fa16bbb
Compare
anoop-dryad
approved these changes
Mar 24, 2026
|
Please disregard my approval (I can't undo it apparently) I thought I was working on another repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The choices param can be usefull to populate list of possible values and to instantiate a ChoiceField on the serializer, even when the field is non_editable.
Relevant for the live doc and the OpenAPI integration.
Description
The fix consist into moving the
choiceskwargs populating step, before the early return for non_editable fields.just before: