Skip to content

Conversation

pprados
Copy link

@pprados pprados commented Jun 25, 2025

Given this is a project maintained by volunteers, please read this template to not waste your time, or ours! 😁 -->

Summary

If some scenario, to close the program, the code catch en exception, and try to close itself. But, if this close generate and exception, the code crash with a stacktrace.

    async def __aiter__(self) -> typing.AsyncIterator[bytes]:
        try:
            async for part in self._stream:
                yield part
        except BaseException as exc:
            try:
                await self.aclose()
            except BaseException:
                pass
            raise exc from None

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@cclauss
Copy link
Contributor

cclauss commented Sep 3, 2025

https://peps.python.org/pep-0008 contains clear advice to avoid catching BaseException. Why should that be ignored?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants