-
Notifications
You must be signed in to change notification settings - Fork 1
Update multi-job caching approach #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t ref, by using the workflow run id as part of the cache key; instead of the git ref.
Test failure condition with reversed logic
HowardvanRooijen
approved these changes
Jun 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Code Coverage Summary Report - Linux (No TFM)Summary
CoverageTestLib - 100%
TestLib.Tests - 100%
|
Code Coverage Summary Report - Linux (net8.0)Summary
CoverageTestLib - 100%
TestLib.Tests - 100%
|
Code Coverage Summary Report - Windows (net8.0)Summary
CoverageTestLib - 100%
TestLib.Tests - 100%
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run_id
as the basis for the cache key, to avoid potential race conditions when multiple workflows build the same git ref concurrently