Skip to content

Update multi-job caching approach #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 19, 2025
Merged

Conversation

JamesDawson
Copy link
Contributor

@JamesDawson JamesDawson commented Jun 18, 2025

  • Use the workflow run_id as the basis for the cache key, to avoid potential race conditions when multiple workflows build the same git ref concurrently
  • Use distinctly-named cache keys when storing compilation and packaging outputs
  • Force a build failure when a required cache restore fails
  • Update CI workflows to work with the revised secrets handling

Copy link

github-actions bot commented Jun 18, 2025

Test Results

1 tests  +1   1 ✅ +1   0s ⏱️ ±0s
1 suites +1   0 💤 ±0 
1 files   +1   0 ❌ ±0 

Results for commit 530c036. ± Comparison against base commit 5b07d1e.

♻️ This comment has been updated with latest results.

@endjin-github endjin-github changed the title Update CI validation workflows Update multi-job caching approach Jun 19, 2025
@endjin-github endjin-github marked this pull request as ready for review June 19, 2025 16:22
Copy link
Member

@HowardvanRooijen HowardvanRooijen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

Code Coverage Summary Report - Linux (No TFM)

Summary
Generated on: 06/19/2025 - 16:30:19
Parser: Cobertura
Assemblies: 2
Classes: 2
Files: 2
Line coverage: 100% (4 of 4)
Covered lines: 4
Uncovered lines: 0
Coverable lines: 4
Total lines: 21
Covered branches: 0
Total branches: 0
Method coverage: Feature is only available for sponsors

Coverage

TestLib - 100%
Name Line Branch
TestLib 100% ****
TestLib.Class1 100%
TestLib.Tests - 100%
Name Line Branch
TestLib.Tests 100% ****
TestLib.Tests.Tests 100%

Copy link

Code Coverage Summary Report - Linux (net8.0)

Summary
Generated on: 06/19/2025 - 16:33:33
Parser: Cobertura
Assemblies: 2
Classes: 2
Files: 2
Line coverage: 100% (4 of 4)
Covered lines: 4
Uncovered lines: 0
Coverable lines: 4
Total lines: 21
Covered branches: 0
Total branches: 0
Method coverage: Feature is only available for sponsors

Coverage

TestLib - 100%
Name Line Branch
TestLib 100% ****
TestLib.Class1 100%
TestLib.Tests - 100%
Name Line Branch
TestLib.Tests 100% ****
TestLib.Tests.Tests 100%

@JamesDawson JamesDawson merged commit 0eb5296 into main Jun 19, 2025
14 checks passed
@JamesDawson JamesDawson deleted the feature/update-ci-builds branch June 19, 2025 16:34
Copy link

Code Coverage Summary Report - Windows (net8.0)

Summary
Generated on: 6/19/2025 - 4:35:29 PM
Parser: Cobertura
Assemblies: 2
Classes: 2
Files: 2
Line coverage: 100% (4 of 4)
Covered lines: 4
Uncovered lines: 0
Coverable lines: 4
Total lines: 21
Covered branches: 0
Total branches: 0
Method coverage: Feature is only available for sponsors

Coverage

TestLib - 100%
Name Line Branch
TestLib 100% ****
TestLib.Class1 100%
TestLib.Tests - 100%
Name Line Branch
TestLib.Tests 100% ****
TestLib.Tests.Tests 100%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants