Skip to content

Add workflow to test parse this plugin #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

warp-core
Copy link
Contributor

Copy-pasted from the data files check in endless-sky/endless-sky, with some edits as appropriate.
Running on the PR now just to test that it runs, but we won't be able to run it on other PRs as it is because those will have @2x versions of images that do not exist in the base game, (that's generally the point of PRs here) and I can't tell it to check out the branch for the relevant PR to endless-sky/endless-sky.

@warp-core
Copy link
Contributor Author

ARGH
The test parse script uses the -p argument which doesn't load images or sounds, so this isn't going to be very useful until that is changed.

@warp-core warp-core marked this pull request as draft October 12, 2023 00:09
@TheGiraffe3
Copy link
Member

endless-sky/endless-sky#10469
We have the ability to load images and sounds now. I think this should be ready, once conflicts are resolved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants