-
Notifications
You must be signed in to change notification settings - Fork 1
Add PAYG early boot support #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a6a3f2c
to
134f959
Compare
eos-payg-nonfree's build depends on python module black.
The PAYG components include private code so we need to gate this behind a flag.
Some of the Endless PAYG support is private, so this is gated behind a project option that is off by default (`-o payg`) to ensure eos-build-meta is still buildable by contributors outside of Endless. Changes based on: <https://github.com/endlessm/eos-ostree-builder/blob/master/hooks/os/85-dracut-payg-image.chroot> Part of #11
This is needed for PAYG which uses a special cert.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume the build failure will be checked. Looks good to me from a brief look!
elements/eos/deps.bst
Outdated
- payg == true: | ||
depends: | ||
(>): | ||
- eos/payg/deps.bst |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 46 has already included eos/payg/deps.bst. Is it duplicated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes! good spot
At least one patch to systemd-boot is essential for PAYG support. (Which enables reading the `loaders/` folder via a symlink in a text file -- necessary as OSTree requires some sort of symlink support to deploy the boot config, even on the ESP which is a FAT filesystem). See: #161
This involves a new token so the runner can clone private repos.
So we can see error messages
This helps if e.g. you suspect there's a build failure due to a bug in a particular BuildStream plugin, you update requirements.txt and want to force a rebuild instead of using a cached build.
This depends on and includes #159.
In this PR:
-o payg
project option, to disable PAYG elements by defaultsigning/payg/signed-uki-snakeoil.bst
(this probably isn't very useful)signing/payg/signed-uki-endless.bst
element-o payg true
settingStill to do: