Fix stale schema #6286
Open
Fix stale schema #6286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://json-schema.org/understanding-json-schema/reference/string#dates-and-times Pretty much all products specify already YYYY-MM-DD a.k.a. json-schema format: 'date'. Not 'date-time'. Additionally, the releaseDate key is specified as #/$defs/boolOrDate, which besides the bool variant, accepts json-schema string format: 'date'.
After commit 1312fab, the actual schema has changed; but product-schema.json was left stale. Fix that by factoring out the auto.methods enum into $defs, and repairing the nesting structure in the schema.
|
Thank you for opening this pull request 👍. If you are not familiar with the project, please check out our Contributing Guidelines and our Guiding Principles. Also take a look at our Hacking Guide if you intend to work on site internals. |
BiNZGi
added
the
product-updates
ulidtko
commented
Dec 17, 2024
| @@ -472,7 +488,7 @@ | |||
| "title": "Latest release date", | |||
| "description": "The date of the latest release.", | |||
| "type": "string", | |||
| "format": "date-time" | |||
| "format": "date" | |||
Comment on lines
+74
to
+87
| "type": "object", | ||
| "required": ["methods"], | ||
| "properties": { | ||
| "cumulative": { | ||
| "title": "Mark auto-update as being cumulative (optional, default = false)", | ||
| "description": "When true, data won't be deleted before fetching new data.\nActivating cumulative updates is not recommended for most products, but could be useful for products that:\n - have a long history of releases that is long to fetch,\n - have a history of releases that is not available anymore.", | ||
| "type": "boolean" | ||
| }, | ||
| "methods": { | ||
| "title": "Auto-update configs", | ||
| "description": "See https://github.com/endoflife-date/endoflife.date/wiki/Automation", | ||
| "type": "array", | ||
| "items": { | ||
| "$ref": "#/$defs/automethod" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Two brief commits here, fixing issues in
product-schema.jsonfor validating the frontmatters.See commit messages 👀