Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new product] Deno #6449

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[new product] Deno #6449

wants to merge 1 commit into from

Conversation

tofran
Copy link

@tofran tofran commented Dec 23, 2024

Closes #4160
Adds Deno.

Note, I disrespected the YAML schema in product-schema.json, to keep it as close to the other products. The schema forces:

  • the auto contents to be an array, and not have methods child key.
  • the releases[].latestReleaseDate expects a date-time instead of a date.

Copy link

welcome bot commented Dec 23, 2024

Thank you for opening this pull request 👍. If you are not familiar with the project, please check out our Contributing Guidelines and our Guiding Principles. Also take a look at our Hacking Guide if you intend to work on site internals.

@tofran tofran changed the title Add deno [new product] Deno Dec 23, 2024
@captn3m0 captn3m0 added the new-product This PR adds a new product to the website. label Dec 24, 2024
Copy link
Member

@captn3m0 captn3m0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few suggestions. We need a policy summary before we can merge.

Comment on lines +32 to +33
Deno support policy can be found on the
[Stability and releases documentation page](https://docs.deno.com/runtime/fundamentals/stability_and_releases/).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There needs to be a clear summary of the upstream policy here, instead of just a link. Things to include:

  • Release Cadence
  • Support policy
  • Stability Guarantee
  • Release Channels, including the exact guarantees made by LTS releases.
  • Versioning Policy(?). Does deno use semver?
  • Standard Library stability.

https://endoflife.date/nodejs might be a good reference.

tags: javascript-runtime
permalink: /deno
versionCommand: deno --version
releasePolicyLink: https://github.com/denoland/deno/releases
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
releasePolicyLink: https://github.com/denoland/deno/releases
releasePolicyLink: https://docs.deno.com/runtime/fundamentals/stability_and_releases/
releaseImage: https://docs.deno.com/runtime/fundamentals/images/deno-lts-support.png

Comment on lines +21 to +25
- releaseCycle: "2"
releaseDate: 2024-10-09
eol: false
latest: "2.1.4"
latestReleaseDate: 2024-12-11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is v1 considered EOL? We should add v1 as well to the table.

Using eoas might also be helpful to split between Deno versions receiving active development or only bugfixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-product This PR adds a new product to the website.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request - Product] Deno
2 participants