Skip to content

[python] Remove broken purls #7093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[python] Remove broken purls #7093

wants to merge 3 commits into from

Conversation

usta
Copy link
Member

@usta usta commented Apr 1, 2025

These are all 404

These are all 404
@usta usta added the product-fixes Product content or release fixes that do not count as updates label Apr 1, 2025
@usta usta self-assigned this Apr 1, 2025
@captn3m0
Copy link
Member

captn3m0 commented Apr 1, 2025

A better approach would be to identify the correct package that ought to be used here, and switch to that instead of dropping them all.

A broken link is not necessarily an incorrect PURL, since a PURL -> URL mapping can never be 100% acccurate.

@@ -16,9 +16,6 @@ eoasColumn: true
identifiers:
- purl: pkg:generic/python
- purl: pkg:deb/ubuntu/python
- purl: pkg:deb/ubuntu/python-minimal
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://packages.ubuntu.com/search?keywords=-minimal&searchon=names&suite=all&section=all

packages are called python2.7-minimal
python2-minimal
python3-minimal

Copy link
Member

@captn3m0 captn3m0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these are definitely invalid packages, but more care needs to be taken to ensure any valid purls are not dropped.

@@ -16,9 +16,6 @@ eoasColumn: true
identifiers:
- purl: pkg:generic/python
- purl: pkg:deb/ubuntu/python
- purl: pkg:deb/ubuntu/python-minimal
- purl: pkg:deb/ubuntu/python2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@captn3m0
Copy link
Member

captn3m0 commented Apr 2, 2025

Note: I have not reviewed the entire list of removals. Please check once and let me know.

@BiNZGi
Copy link
Member

BiNZGi commented Apr 16, 2025

We render some purls into urls and the user can click on them. They can return a 404, I assume @usta checked all urls and wants to remove the 404.

For deb/ubuntu it seems that we render this way:
purl: pkg:deb/ubuntu/python2 -> https://launchpad.net/ubuntu/+source/python2

Opening this url returns a 404.

On https://packages.ubuntu.com/python2&exact=1 it returns packages for focal and jammy. In the other distributions the package seems not to be there.

I suggest to change the url pattern for deb/ubuntu purls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product-fixes Product content or release fixes that do not count as updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants