-
-
Notifications
You must be signed in to change notification settings - Fork 962
[python] Remove broken purls #7093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
These are all 404
A better approach would be to identify the correct package that ought to be used here, and switch to that instead of dropping them all. A broken link is not necessarily an incorrect PURL, since a PURL -> URL mapping can never be 100% acccurate. |
@@ -16,9 +16,6 @@ eoasColumn: true | |||
identifiers: | |||
- purl: pkg:generic/python | |||
- purl: pkg:deb/ubuntu/python | |||
- purl: pkg:deb/ubuntu/python-minimal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://packages.ubuntu.com/search?keywords=-minimal&searchon=names&suite=all§ion=all
packages are called python2.7-minimal
python2-minimal
python3-minimal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of these are definitely invalid packages, but more care needs to be taken to ensure any valid purls are not dropped.
@@ -16,9 +16,6 @@ eoasColumn: true | |||
identifiers: | |||
- purl: pkg:generic/python | |||
- purl: pkg:deb/ubuntu/python | |||
- purl: pkg:deb/ubuntu/python-minimal | |||
- purl: pkg:deb/ubuntu/python2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: I have not reviewed the entire list of removals. Please check once and let me know. |
We render some purls into urls and the user can click on them. They can return a 404, I assume @usta checked all urls and wants to remove the 404. For deb/ubuntu it seems that we render this way: Opening this url returns a 404. On https://packages.ubuntu.com/python2&exact=1 it returns packages for I suggest to change the url pattern for deb/ubuntu purls. |
These are all 404