-
-
Notifications
You must be signed in to change notification settings - Fork 960
[New Product] Phoenix framework #7802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We wont add any future or alpha/beta/rc releases
@usta is there anything else that i need to do here? I removed the incorrect policy link and clicked all the links in the release build. |
Document release policy and mark 1.3 as unsupported
Made a few changes based on the documented policy. This includes marking 1.3 as unsupported, creating a eoas column for "Bug Fixes", and setting a proper EOL/EOAS date everywhere. Also trimmed the text a bit - Phoenix doesn't follow semver since breaking changes happen in |
Also renamed to |
LGTM: https://deploy-preview-7802--endoflife-date.netlify.app/phoenix @StephanH90 @usta please take a look. |
@captn3m0 looks good. Thank you so much for your help. |
Just realized this doesn't have identifiers - will add that and merge. |
Also suggest to change its title because Phoenix is a bit too generic ( there are other software which share same name ) so i think it might be better to change its title to |
Yeah, I think thats reasonable considering the domain is https://phoenixframework.org and it even shows in the main header of the page: |
Yeah, it felt off to me as well, Will change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
oww i'm seeing some errors on lint : /home/runner/work/endoflife.date/endoflife.date/_plugins/identifier-to-url.rb:40:in render': Missing method handler _build_hex_url for PURL type hex (RuntimeError) from /home/runner/work/endoflife.date/endoflife.date/_plugins/end-of-life-filters.rb:133:in identifier_to_url'
|
Not %100 sure it is caused by this PR or not |
This PR only, this is the first Hex package we're adding, and I never added support for Hex PURLs. Can attach it to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now looks like everything ok
Thank you and congratulations for your first contribution! endoflife.date is a community wiki, and we're always looking for more contributions 🥇 💯 🎉. |
Adds Phoenix Framework