feat(compartment-mapper): support treating top-level return in CJS as a way to export from module #2762
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One of the rarely used ways to export from a CJS module is to
return
a reference instead of settingmodule.exports
to that reference. This PR adds support for that behavior and a tiny fixture in tests to ensure it works in all scenarios.Security Considerations
N/A
Scaling Considerations
N/A
Documentation Considerations
It's part of CJS and also something very few people know. Documenting it would lead to more confusion than not.
Testing Considerations
Covered with a case in existing test coverage.
Compatibility Considerations
Increases ecosystem compatibility by the few unfortunate packages that use this way of exporting.
Upgrade Considerations
None