Update README.md #2950
Open
Update README.md #2950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an explanation to first time repository setup that would've saved me a little research as a non-lerna-native.
kriskowal
reviewed
Sep 10, 2025
|
|
||
| ## Contributing | ||
|
|
||
| This repository uses lerna as a monorepo, to allow the included packages to depend on each other. |
Member
There was a problem hiding this comment.
I think the cross-package linking is a yarn feature and the tooling for publishing is facilitated by lerna, but the boundary is vague in my mind.
Member
There was a problem hiding this comment.
And maybe link CONTRIBUTING.md.
kriskowal
approved these changes
Sep 10, 2025
|
|
||
| ## Contributing | ||
|
|
||
| This repository uses lerna as a monorepo, to allow the included packages to depend on each other. |
Member
There was a problem hiding this comment.
And maybe link CONTRIBUTING.md.
kriskowal
requested changes
Sep 10, 2025
Member
kriskowal
left a comment
kriskowal
left a comment
There was a problem hiding this comment.
Please change the commit message to a conventional commit, like:
docs: Add getting started instructions for contributors to README
Member
|
Also, I’m sure it would have helped to have a call-out to https://www.conventionalcommits.org/en/v1.0.0/ in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an explanation to first time repository setup that would've saved me a little research as a non-lerna-native.