-
Notifications
You must be signed in to change notification settings - Fork 80
feat(harden): Surface harden before lockdown #2989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kriskowal
wants to merge
22
commits into
master
Choose a base branch
from
kriskowal-endo-harden-shallow
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Note to self: when I pick this up again, @erights and I are in agreement to use the term “surface” rather than “shallow”, as opposed to “volume”. |
e5182ab to
d52dcb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #2983
Description
This change introduces an
@endo/hardenpackage that has three modes, as documented in the new README.post-lockdown All of these modes adopt the behavior of the global or intrinsic
hardenafterlockdown. All of these modes causelockdownto fail ifhardenis used beforelockdown.presume post-lockdown In order to minimize bundle size increase, the
-C hardenedbundler condition can omit a user code implementation ofhardenand rely on the global environment, failing if the global environment lacks ahardenglobal or intrinsic.shallow The default behavior before lockdown is to transitively freeze own properties and to not traverse prototype chains. This makes the mode suitable for non-lockdown environments that tend to make uncoordinated changes to shared intrinsics, but preserves a sense of hardening for shallow immutability.
unsafe In order to use Hardened Modules without the performance penalty of even a shallow freeze, electing
-C harden:unsafewill provide a fakehardenimplementation that freezes nothing.Security Considerations
Each of these modes provides different security footing.
Scaling Considerations
Build conditions are provided to compensate for difficulties scaling, both for performance and bundle size increases consequent on adopting
@endo/hardenfor a hardened module.Documentation Considerations
The new package’s README is comprehensive.
Testing Considerations
All modes are covered. The shortfall in coverage mostly pertains to shimmed behavior like
hasOwn.Compatibility Considerations
Adopting
@endo/hardenwill, by itself, increase bundle sizes. We consider it acceptable to obligate applications with sensitive bundle sizes to also adopt-C hardenedin their build procedures to mitigate the increase.This overall effect of this change is to increase the portability of Hardened modules with frontend and testing environments that require uncoordinated modification to shared intrinsics.
Upgrade Considerations
None.