Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

seriesRLC init #111

Merged
merged 4 commits into from
May 18, 2023
Merged

seriesRLC init #111

merged 4 commits into from
May 18, 2023

Conversation

Lakshmikanth2001
Copy link
Contributor

resolving #104

@Lakshmikanth2001
Copy link
Contributor Author

white space is present that's the reason pydocstyle is failing if you are ok with the function let me know

@Lakshmikanth2001
Copy link
Contributor Author

frequencyResponse

engineerjoe440
engineerjoe440 requested changes May 18, 2023
View reviewed changes
Copy link
Owner

@engineerjoe440 engineerjoe440 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one comment, then let's slam this in!

electricpy/visu.py Outdated Show resolved Hide resolved
engineerjoe440
engineerjoe440 requested changes May 18, 2023
View reviewed changes
test/test_opamp.py Outdated Show resolved Hide resolved
test/RLC_frequency_response.png Outdated Show resolved Hide resolved
@engineerjoe440 engineerjoe440 merged commit 56db8d6 into engineerjoe440:develop May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engineerjoe440 engineerjoe440 engineerjoe440 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lakshmikanth2001 @engineerjoe440