Revert "fix: Fixed pub_multi_track.sh frame rate" #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's one such example of corrupted output from attempting to mux together renditions with different framerates: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #21
This appears to be causing some kind of corruption in the ffmpeg output and blocking progress on adding ABR switching logic to moq-js: englishm/moq-js#55
I've tried a few variations on this, but, so far, every time I mux multiple video streams with different frame rates together, I end up with corrupted output. (True when writing to a local file as well - this is separate from
moq-pub) When the output is not corrupted it also seems to be the case that the framerates end up being identical for each rendition. Reverting until we can implement a proper fix.