update #1
Merged
update #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change provides a step-by-step algorithm for how to pick the next object to send, and which priorities take precedence over another, all in one place. This PR may or may not change the normative behavior of priorities depending on one's interpretation of the current text (which, as we learned in today's call, appears to vary between people). Fixes #517
Co-authored-by: ianswett <[email protected]>
Adds three new error codes: - Track Does Not Exist (0x3) - Unauthorized (0x4) - Timeout (0x5) As discussed in #347
The draft is missing a number.
As I was reading through the draft, I found some slight typos in the publisher interactions segment. This fixes them!
As of now, we use Subscribe ID for operations on a subscriber, and Track Alias for operations on objects. In #581, there was an effort to remove referencing subscribe id within object header types, but one slipped through. This fixes that.
We don't discuss how to use it anyway. This was suggested in #589
This change provides a step-by-step algorithm for how to pick the next object to send, and which priorities take precedence over another, all in one place. This PR may or may not change the normative behavior of priorities depending on one's interpretation of the current text (which, as we learned in today's call, appears to vary between people). Fixes #517 Closes #585
This is an attempt at clarifying MAX_SUBSCRIBE_ID, feel free to make suggestions. Fixes #547
🐤 Fixes: #612
We said we might do this after adding MAX_SUBSCRIBE_ID, so here it is. Motivated by a comment on #572
This is an attempt at clarifying MAX_SUBSCRIBE_ID, feel free to make suggestions. Fixes #547
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.