Update example to remove AsyncGenerator (#654) #655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AsyncGenerators are not safe to use outside of toy examples. The `next()` function will block any call to `return()` or `throw()` if it is waiting on a promise. To avoid this pitfall, implementations should not use the native `async function*()` syntax and should instead provide their own `AsyncIterator` implementations.
enisdenjo
requested changes
Sep 1, 2025
There was a problem hiding this comment.
Thanks for working on this! However, I feel like the 50 lines of EventProvider for the getting started is too much. I instead recommend using RepeaterJS here.
If you want to talk about the asyngenerator quirks, maybe add it somewhere else? A new page? Recipes?
Sure, moved the longer explanation to recipes and made the getting started example use Repeater.js |
|
Any other feedback, or is this good to merge? |
enisdenjo
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AsyncGenerators are not safe to use outside of toy examples. The
next()function will block any call toreturn()orthrow()if it is waiting on a promise. To avoid this pitfall, implementations should not use the nativeasync function*()syntax and should instead provide their ownAsyncIteratorimplementations.