feat: universal resolver safe calls + success var return #292
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes:
UniversalResolver
significantly more stable in it's return valuesBatchGateway
's errors are now documented within solidity. HTTP errors now useHttpError(tuple(uint16 status, string message)[])
to differentiate them from regular solidity errors.resolve
(resolve(bytes,bytes)
/etc) calls will now revert if the call was unsuccessful, rather than just returning the error data.ResolverError(bytes)
. this makes it easier to identify when an error is coming from the UniversalResolver itself, or an external resolver.HttpError(tuple(uint16 status, string message)[])
resolve
are nowtuple(bool success, bytes returnData)
, rather than justbytes
ResolverNotContract
error for if a name's resolver is not a contractsupportsInterface