-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delegatable resolver registrar #295
Closed
makoto
wants to merge
5
commits into
feature/crosschain-resolver-with-reverse-registrar
from
delegatable-resolver-registrar
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
// SPDX-License-Identifier: MIT | ||
pragma solidity >=0.8.4; | ||
import "./IDelegatableResolverRegistrar.sol"; | ||
import "./DelegatableResolver.sol"; | ||
import "@openzeppelin/contracts/utils/introspection/ERC165.sol"; | ||
|
||
/** | ||
* A delegated resolver registrar that allows anyone to register subname | ||
*/ | ||
contract DelegatableResolverRegistrar is IDelegatableResolverRegistrar, ERC165 { | ||
DelegatableResolver public resolver; | ||
|
||
constructor(DelegatableResolver _resolver) { | ||
resolver = _resolver; | ||
} | ||
|
||
/** | ||
* @dev Approve an operator to be able to updated records on a node. | ||
* @param name The encoded subname | ||
* @param operator The address to approve | ||
*/ | ||
|
||
function register(bytes memory name, address operator) external { | ||
(bytes32 node, bool authorized) = resolver.getAuthorisedNode( | ||
name, | ||
0, | ||
operator | ||
); | ||
if (authorized == false) { | ||
resolver.approve(name, operator, true); | ||
} | ||
} | ||
|
||
function supportsInterface( | ||
bytes4 interfaceId | ||
) public view override returns (bool) { | ||
return | ||
interfaceId == type(IDelegatableResolverRegistrar).interfaceId || | ||
super.supportsInterface(interfaceId); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
// SPDX-License-Identifier: MIT | ||
pragma solidity >=0.8.4; | ||
|
||
interface IDelegatableResolverRegistrar { | ||
function register(bytes memory name, address operator) external; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this does what you want. It won't prevent duplicate subdomains, because it only prevents the same person being issued the same name twice. I think instead you need to keep a mapping of issued names, or modify the DelegatableResolver to keep track of issued names.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's my intention. I only added it to avoiding existing operator to waste the gas. Not sure restricting multiple subname operators at registrar level makes sense because the owner of the resolver contract can always approve multiple operators. If we want to change the delegatable resolver to only have single owner per subname, I think I need to add registrar feature directly in the resolver as @jefflau initially suggested.