Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused interface "commitments" from IETHRegistrarController #312

Merged
merged 1 commit into from
Jan 22, 2024
Merged

remove unused interface "commitments" from IETHRegistrarController #312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ yarn pub

### Cherry-picked release flow

Certain changes can be released in isolation via cherry-picking, although ideally we would always release from `staging`.
Certain changes can be released in isolation via cherry-picking, although ideally we would always release from `staging`.

1. Create a new branch from `mainnet`.
2. Cherry-pick from `staging` into new branch.
Expand Down
2 changes: 0 additions & 2 deletions contracts/ethregistrar/IETHRegistrarController.sol
View file
Open in desktop
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0x34e833fF697Ad8dE8c79911D5fCa6f5bF8eda0C7

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ interface IETHRegistrarController {

function commit(bytes32) external;

function commitments(bytes32) external view returns (uint256);

function register(
string calldata,
address,
Expand Down