-
Notifications
You must be signed in to change notification settings - Fork 335
Remove ===== style section headers from Dashboard
#12630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🧪 Storybook is successfully deployed!📊 Dashboard:
|
|
What is the reasoning here? I think in a lot of cases these comments help navigate big source files. |
|
Even though these comments are obsolete for Dashboard code (we prefer smaller files), I’m certain we need to discuss this with the |
|
yeah i think in project view they're used better, in the dashboard most files are on the smaller side so they're often used to annotate the single export |
farmaazon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, please spare headers in project-view files.
BTW, these are not particularly "rust specific", these are just our headers. Scala files have similar.
0e4ee3d to
b776e7d
Compare
===== style section headers
===== style section headers===== style section headers from Dashboard
|
pinging @MrFlashAccount for CR. QA should not be needed because there are no code changes |
- Remove `======` section headers from Dashboard codebase # Important Notes Let me know if some comments should be preserved as doc-style comments. This is a quick-and-dirty refactor using find-and-replace with the empty string. Search string used in VS Code included below for posterity. ``` (// =+) // ===.+ \1 ``` Note that the trailing and leading newline are important.
Pull Request Description
======section headers from Dashboard codebaseImportant Notes
Let me know if some comments should be preserved as doc-style comments. This is a quick-and-dirty refactor using find-and-replace with the empty string. Search string used in VS Code included below for posterity.
Note that the trailing and leading newline are important.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
The documentation has been updated, if necessary.Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
Unit tests have been written where possible.If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,or the Snowflake database integration, a run of the Extra Tests has been scheduled.
If applicable, it is suggested to paste a link to a successful run of the Extra Tests.