-
Notifications
You must be signed in to change notification settings - Fork 334
Trace local variable read/write via Truffle instrumentation #14540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JaroslavTulach
wants to merge
11
commits into
develop
Choose a base branch
from
wip/InstrumentReadWrite10525
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+397
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
JaroslavTulach
commented
Dec 28, 2025
Comment on lines
+79
to
+84
| writeVariableNameEnter r | ||
| readVariableNameEnter b | ||
| readVariableNameReturn = 15 | ||
| readVariableNameEnter a | ||
| readVariableNameReturn = 7 | ||
| writeVariableNameReturn = 8 |
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- this test for example shows that since the assignment of variable
rstarts (withwriteVariableNameEnter rmessage)- we need to read variable
b(with value15) - and read variable
a(with value7)
- we need to read variable
- to finish the assignment and place value
8to the slot of variabler - would this be useful for tracking reactive dependencies between local variables, @hubertp?
Akirathan
approved these changes
Dec 29, 2025
Member
Akirathan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems useful. Minor suggestion to add docs for assignmentBounds.
engine/runtime/src/main/java/org/enso/interpreter/node/scope/AssignmentNode.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI: Clean build required
CI runners will be cleaned before and after this PR is built.
CI: No changelog needed
Do not require a changelog entry for this PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
ReadVariableTagandWriteVariableTagto EnsoChecklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Java,