-
Notifications
You must be signed in to change notification settings - Fork 336
Add org.jline as module to component directory #8496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
engine/runtime/src/main/java/org/enso/ClassLoaderConstants.java
Outdated
Show resolved
Hide resolved
distribution/bin/enso.bat
Outdated
| ) | ||
| ) | ||
| java --module-path %comp-dir% -Dpolyglot.compiler.IterativePartialEscape=true %EXTRA_OPTS% %JAVA_OPTS% -m org.enso.runtime/org.enso.EngineRunnerBootLoader %* | ||
| java --module-path %comp-dir% --add-modules org.jline -Dpolyglot.compiler.IterativePartialEscape=true %EXTRA_OPTS% %JAVA_OPTS% -m org.enso.runtime/org.enso.EngineRunnerBootLoader %* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be better to avoid these add-modules modifications. If we are sure we want to use org.jline as a module in enso, then I'd suggest to modify module-info.java to require static org.jline. Then the standard JVM launcher shall pick the org.jline module up, when it is available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. Let's avoid --add-modules.
|
@JaroslavTulach At the end, this PR is minimalistic - just 8 new lines. It turns out it was enough to set the thread context class loader before the jLine initialization. |
Fixes #8313
Pull Request Description
Add
jlinemodule to the distribution so that our REPL is usable again.Important Notes
CTRL + R) works as expected.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.