Add custom icons for OpenRouter, Uptimerobot, Dhan #8679
Conversation
|
|
There was a problem hiding this comment.
Pull request overview
This PR adds custom icons for three authentication services: OpenRouter (openrouter.ai), Uptimerobot (uptimerobot.com), and Dhan (dhan.co). The changes include both the SVG icon files and corresponding metadata entries in the custom icons JSON file.
Changes:
- Added 3 optimized SVG icon files for the new services
- Added JSON metadata entries with slugs, hex colors, and alternative names for better issuer matching
- Reformatted existing JSON entries from multi-line to single-line format for
altNamesarrays
Reviewed changes
Copilot reviewed 1 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| mobile/apps/auth/assets/custom-icons/icons/uptimerobot.svg | New SVG icon for Uptimerobot service with green circular design |
| mobile/apps/auth/assets/custom-icons/icons/openrouter.svg | New SVG icon for OpenRouter service with router/network path design |
| mobile/apps/auth/assets/custom-icons/icons/dhan.svg | New SVG icon for Dhan securities service with gradient and logo design |
| mobile/apps/auth/assets/custom-icons/_data/custom-icons.json | Added metadata for 3 new icons and reformatted existing altNames to single-line format |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Thank you for the contribution. But it will be great if you could not change the default formatting of our files. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 4 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "title": "tencent cloud", | ||
| "slug": "tencent_cloud", | ||
| "altNames": [ | ||
| "腾讯云", | ||
| "tencentcloud" | ||
| ] | ||
| "altNames": ["腾讯云", "tencentcloud"] | ||
| }, | ||
| { | ||
| "title": "Techlore", | ||
| "altNames": [ | ||
| "Techlore Courses", | ||
| "Techlore Forums" | ||
| ] | ||
| "altNames": ["Techlore Courses", "Techlore Forums"] | ||
| }, | ||
| { | ||
| "title": "Teleport", | ||
| "altNames": [ | ||
| "Gravitational Teleport", | ||
| "GoTeleport" | ||
| ] | ||
| "altNames": ["Gravitational Teleport", "GoTeleport"] | ||
| }, | ||
| { | ||
| "title": "tencent cloud", | ||
| "slug": "tencent_cloud", | ||
| "altNames": [ | ||
| "腾讯云", | ||
| "tencentcloud" | ||
| ] | ||
| "altNames": ["腾讯云", "tencentcloud"] | ||
| }, |
There was a problem hiding this comment.
Duplicate entry detected: "tencent cloud" appears twice in the JSON (lines 1412-1414 and 1425-1427) with identical configuration. One of these entries should be removed to avoid confusion and potential issues with icon matching.
| "title": "Dhan", | ||
| "slug": "dhan", | ||
| "altNames": ["dhan.co", "Dhan Securities"], | ||
| "hex": "4575D9" |
There was a problem hiding this comment.
The hex color value "4575D9" (blue) does not match the actual colors used in the dhan.svg file, which uses green colors (#138c61, #4dba93, #17875f, #269970). The hex value should represent the primary brand color from the SVG. Consider using one of the green colors from the SVG, such as "269970" for consistency.
| "hex": "4575D9" | |
| "hex": "269970" |
| }, | ||
| { | ||
| "title": "Animal Crossing", | ||
| "slug:": "animal_crossing", |
There was a problem hiding this comment.
Typo in field name: "slug:" should be "slug" (without the colon). This will cause the slug field to not be recognized properly.
| "slug:": "animal_crossing", | |
| "slug": "animal_crossing", |
| "title": "Upstox" | ||
| }, | ||
| { | ||
| "title": "Uptimerobot", |
There was a problem hiding this comment.
The title "Uptimerobot" does not match the official brand name "UptimeRobot" (with capital R). The title should be updated to "UptimeRobot" for consistency with the brand and the altNames field.
| "title": "Uptimerobot", | |
| "title": "UptimeRobot", |
There are a lot of issues in this PR, I would recommend you to close this and open a new PR |
|
@somritdasgupta Please remove the formatting changes. |
4 participants
Description
Adds custom icons for three services currently missing from Ente Auth:
Changes Made
mobile/apps/auth/assets/custom-icons/icons/mobile/apps/auth/assets/custom-icons/_data/custom-icons.jsonwith metadata (slug, hex, altNames)Technical Details
Tests