[mob][locker] Migrate dialogs to bottom sheets for consistent UI #8703
Conversation
Replace showDialog with showBaseBottomSheet across Locker app and packages/accounts for better mobile UX consistency. Co-Authored-By: Claude <[email protected]>
…ollectionDialog and FileRestoreDialog
AmanRajSinghMourya
force-pushed
the
improvements
branch
from
ecb78e4 to
dd57d4d
Compare
…dit, share, and mark important functionalities
…tors and improve avatar display
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8b7925a9fc
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| final result = await showFileEditSheet( | ||
| context, | ||
| file: file, | ||
| collections: editableCollections, |
There was a problem hiding this comment.
The edit flow now goes straight into showFileEditSheet without verifying that the current user owns the file. Since FilePopupMenuWidget always exposes the Edit action, a user can open the edit sheet for a shared file and attempt metadata/collection updates that were previously blocked. This conflicts with the rest of the UI (e.g., selection overlay still treats shared edits as unsupported) and can result in unauthorized edits or confusing failures. Consider restoring the ownership check in FileActions.editFile or hiding the menu action for non-owners.
Useful? React with 👍 / 👎.
| await showInputSheet( | ||
| context, | ||
| title: context.l10n.renameCollection, |
There was a problem hiding this comment.
CollectionActions.editCollection now unconditionally opens the rename sheet and applies the rename. The collection model defines favorites and uncategorized as canEdit == false, and callers like the collection selection overlay only filter by ownership. That means those system collections can now be renamed when selected, which is likely unsupported and was previously blocked. Reintroduce the canEdit guard here or ensure callers filter out non-editable types before invoking rename.
Useful? React with 👍 / 👎.
Description
Replace showDialog with bottomsheets across Locker app and packages/accounts for better mobile UX consistency.
Fix color, spacing, padding and other theming parameters