Skip to content

Master #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 2, 2024
Merged

Master #39

merged 11 commits into from
Nov 2, 2024

Conversation

entelecheia
Copy link
Owner

@entelecheia entelecheia commented Nov 2, 2024

Summary by Sourcery

Update project dependencies and CI workflows, and increment the version to 2.0.5. Revise the semantic release configuration and update the CHANGELOG for the new release.

Build:

  • Update the build system to require 'poetry-core>=1.0.0' and set 'poetry.core.masonry.api' as the build-backend.

CI:

  • Revise the CI workflow to trigger on push events to branches matching 'release*' and 'test-release*', and update the steps for semantic version release and package publishing.

Documentation:

  • Update the CHANGELOG.md to include the changes for version 2.0.5.

semantic-release and others added 11 commits August 18, 2024 18:55
Automatically generated by python-semantic-release
Merge pull request #34 from entelecheia/master
Bumps [nltk](https://github.com/nltk/nltk) from 3.9 to 3.9.1.
- [Changelog](https://github.com/nltk/nltk/blob/develop/ChangeLog)
- [Commits](nltk/nltk@3.9...3.9.1)

---
updated-dependencies:
- dependency-name: nltk
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [pandas](https://github.com/pandas-dev/pandas) from 2.2.2 to 2.2.3.
- [Release notes](https://github.com/pandas-dev/pandas/releases)
- [Commits](pandas-dev/pandas@v2.2.2...v2.2.3)

---
updated-dependencies:
- dependency-name: pandas
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
build(deps): bump pandas from 2.2.2 to 2.2.3
Bumps [fugashi](https://github.com/polm/fugashi) from 1.3.2 to 1.3.3.
- [Release notes](https://github.com/polm/fugashi/releases)
- [Commits](polm/fugashi@v1.3.2...v1.3.3)

---
updated-dependencies:
- dependency-name: fugashi
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Copy link

codesandbox bot commented Nov 2, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@zube zube bot added the [zube]: Inbox label Nov 2, 2024
@entelecheia entelecheia merged commit 903f546 into release Nov 2, 2024
1 check passed
Copy link

sourcery-ai bot commented Nov 2, 2024

Reviewer's Guide by Sourcery

This PR updates the project's version to 2.0.5, modernizes the semantic release configuration, updates dependencies, and refactors the GitHub Actions workflows for releases. The changes primarily focus on infrastructure improvements and dependency management.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated project dependencies and version
  • Bumped project version from 2.0.4 to 2.0.5
  • Updated fugashi from ^1.3.0 to ^1.3.3
  • Updated pandas upper bound from 2.2.2 to 2.2.3
  • Updated python-semantic-release from ^7.33.1 to ^9.0.0
  • Updated black from >=23.0.0 to ^24.0.0
pyproject.toml
src/ekonlpy/_version.py
Modernized semantic-release configuration
  • Removed setuptools_scm configuration
  • Added detailed semantic-release configuration sections
  • Configured commit parsing rules and version bumping logic
  • Added branch settings for release management
  • Configured publish settings for package distribution
pyproject.toml
Refactored GitHub Actions release workflows
  • Updated workflow triggers to use push events instead of workflow_run
  • Implemented modern semantic-release GitHub Action
  • Added separate steps for PyPI and GitHub releases
  • Improved repository checkout and branch handling
  • Updated test release workflow to match production workflow structure
.github/workflows/release.yaml
.github/workflows/release-test.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@zube zube bot added [zube]: Done and removed [zube]: Inbox labels Nov 2, 2024
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @entelecheia - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

# Load all steps #
release:
runs-on: ubuntu-latest
concurrency: release
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (bug_risk): Specify cancel-in-progress for release concurrency

Add cancel-in-progress: true to the concurrency configuration to prevent race conditions between multiple release workflows running simultaneously.

Suggested change
concurrency: release
concurrency:
group: release
cancel-in-progress: true

@zube zube bot removed the [zube]: Done label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant