Never return null when mapping to protobuf format objects #498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 24, 2025 09:55
# Conflicts: # support-core/src/main/java/no/entur/abt/mapstruct/common/ProtobufStandardMappings.java
This was referenced Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Null return values when mapping to protobuf format will cause nullPointerExceptions in builders.
This includes the parts of the suggested change from #177 that concerns mapping TO protbuf types, but not the parts concerning mapping FROM protobuf types. For the latter the current impl of returning null for empty/defaultInstance values has some merit as it is the only way for clients to detect and handle not populated fields. The suggestion of supporting multiple implementations for mapping FROM protobuf format (from #177) still looks like viable option for allowing clients to choose between null/empty values
This should also support half of #451 in a similar way