feat: support bedrock reasoning content response #1074
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexa Griffith <[email protected]>
Signed-off-by: Alexa Griffith <[email protected]>
Signed-off-by: Alexa Griffith <[email protected]>
Signed-off-by: Alexa Griffith <[email protected]>
Signed-off-by: Alexa Griffith <[email protected]>
Signed-off-by: Alexa Griffith <[email protected]>
Signed-off-by: Alexa Griffith <[email protected]>
…ub.com/alexagriffith/ai-gateway into alexagriffith/support-bedrock-thinking
alexagriffith
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1074 +/- ##
==========================================
- Coverage 78.33% 78.13% -0.21%
==========================================
Files 81 82 +1
Lines 9349 9629 +280
==========================================
+ Hits 7324 7524 +200
- Misses 1681 1749 +68
- Partials 344 356 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Alexa Griffith <[email protected]>
| @@ -467,21 +513,20 @@ func (o *openAIToAWSBedrockTranslatorV1ChatCompletion) bedrockStopReasonToOpenAI | |||
|
|
|||
| func (o *openAIToAWSBedrockTranslatorV1ChatCompletion) bedrockToolUseToOpenAICalls( | |||
| toolUse *awsbedrock.ToolUseBlock, | |||
| ) *openai.ChatCompletionMessageToolCallParam { | |||
| ) openaigo.ChatCompletionMessageToolCall { | |||
There was a problem hiding this comment.
switch to a pointer return?
There was a problem hiding this comment.
we just dereference the ptr right after returning, what do u think is best to do?
| }, | ||
| FinishReason: o.bedrockStopReasonToOpenAIStopReason(bedrockResp.StopReason), |
There was a problem hiding this comment.
can we set the finishReason inplace?
| if choice.Message.Content == nil { | ||
| choice.Message.Content = output.Text | ||
| switch { | ||
| case output.ToolUse != nil: |
There was a problem hiding this comment.
ToolUse and Text cannot be non-nil at the same time, right?
if yes, can you add comment about it or point to docs about it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
support returning reasoning content from aws bedrock in openai.
required adding aws bedrock fields that were missing and requires returning extra fields. since we are already refactoring to use openai go sdk, it makes sense to implement this here instead of adding it to our custom openai struct.