Skip to content

chore: updates to Go 1.25 and refactors some code #1077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

codefromthecrypt
Copy link
Contributor

Description

This updates to Go 1.25 and uses some new features.

See https://tip.golang.org/doc/go1.25

@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2025

Codecov Report

❌ Patch coverage is 98.30508% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 78.55%. Comparing base (293cc0a) to head (751057f).

Files with missing lines Patch % Lines
tests/internal/testenvironment/test_environment.go 0.00% 1 Missing ⚠️

❌ Your project status has failed because the head coverage (78.55%) is below the target coverage (86.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1077      +/-   ##
==========================================
+ Coverage   78.29%   78.55%   +0.26%     
==========================================
  Files          82       82              
  Lines        9642     9639       -3     
==========================================
+ Hits         7549     7572      +23     
+ Misses       1734     1716      -18     
+ Partials      359      351       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gonzaloserrano
Copy link

In case you find it useful: https://pkg.go.dev/golang.org/x/tools/gopls/internal/analysis/modernize

go run golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest -fix -test ./...

Signed-off-by: Adrian Cole <[email protected]>
@codefromthecrypt
Copy link
Contributor Author

codefromthecrypt commented Aug 14, 2025

@gonzaloserrano thanks a lot! added! (except json tag changes)

Note it seems coverage changed a bit hence we're not hitting targets like before..

Signed-off-by: Adrian Cole <[email protected]>
@codefromthecrypt
Copy link
Contributor Author

I will try to vibe some coverage to get us over the line

Signed-off-by: Adrian Cole <[email protected]>
Signed-off-by: Adrian Cole <[email protected]>
@mathetake mathetake added this to the v0.4.0 milestone Aug 14, 2025
@mathetake
Copy link
Member

looking cool... the discussion was that we will start using 1.25 after v0.3 which will happen within a few days 🤞

@codefromthecrypt
Copy link
Contributor Author

cool as I'm out of time vibing for the next few days anyway ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants