feat: support gcp service account key file and gcp doc #1090
+515
−101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Sun <[email protected]>
Signed-off-by: Dan Sun <[email protected]>
Signed-off-by: Dan Sun <[email protected]>
Signed-off-by: Dan Sun <[email protected]>
Signed-off-by: Dan Sun <[email protected]>
Signed-off-by: Dan Sun <[email protected]>
yuzisun
changed the title
Signed-off-by: Dan Sun <[email protected]>
Signed-off-by: Dan Sun <[email protected]>
Signed-off-by: Dan Sun <[email protected]>
mathetake
reviewed
Aug 18, 2025
| type GCPCredentialsFile struct { | ||
| // SecretRef is the reference to the credential file. | ||
| // | ||
| // The secret should contain the AWS credentials file keyed on "credentials". |
mathetake
reviewed
Aug 18, 2025
| @@ -285,3 +291,12 @@ type AWSOIDCExchangeToken struct { | |||
| // +kubebuilder:validation:MinLength=1 | |||
| AwsRoleArn string `json:"awsRoleArn"` | |||
| } | |||
|
|
|||
| // GCPCredentialsFile specifies the credentials file to use for the GCP provider. | |||
| // Envoy reads the secret file to authenticate with GCP. | |||
There was a problem hiding this comment.
i think we should fix the doc on AWSCredentialsFile as well but it's not Envoy who reads the credentials but Envoy AI Gateway controller does
mathetake
reviewed
Aug 18, 2025
Comment on lines
+81
to
+88
| creds, err := google.CredentialsFromJSON(ctx, []byte(g.gcpServiceAccountJSON), "https://www.googleapis.com/auth/cloud-platform") | ||
| if err != nil { | ||
| return err | ||
| } | ||
| token, err := creds.TokenSource.Token() | ||
| if err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
when the secret gets updated, then the extproc config also gets updated, so it should fine to do this during the handler setup in newGCPHandler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the support for GCP static service account credential file for an easier way to show case how to access GenAI models on GCP VertexAI.
Related Issues/PRs (if applicable)
Fixes #1015