build: use Bazel 1.1.0 #8739
build: use Bazel 1.1.0 #8739
Conversation
Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou <[email protected]>
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
If this works and docs still build etc. then ship it. I have no idea why it is so inelegant to be passing file paths around in Bazel aspects, so basically "as long as it works" is the best we can do.
Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou <[email protected]>
| "--enable-frame-pointers", | ||
| "--disable-libunwind", | ||
| ], | ||
| ] + select({ |
There was a problem hiding this comment.
@keith I believe this is workaround for bazelbuild/bazel#9154
There was a problem hiding this comment.
We should update rules_foriegn_cc instead where this is fixed
There was a problem hiding this comment.
@keith No that doesn't fix, I guess rules_foreign_cc only fixed cmake, not configure_make, I still need this one.
There was a problem hiding this comment.
We should fix it there too then 😞
Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou <[email protected]>
This reverts commit 5ff7bc8. Signed-off-by: Lizan Zhou <[email protected]>
|
@htuch let's not block on the upstream patches? |
|
@lizan I'm inclined as a general principle to make a best effort to merge patches upstream first. Not a huge fan of building up patches. But, if you think this is time sensitive, or is blocking something else, I'm cool with making that async. |
|
@htuch agreed on upstream first, but I'd also like to get bazel up-to-date before stable release. |
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Agreed if we can't land the patches by Monday let's land this before we cut 1.12.0
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
Sure, let's get this in for 1.12.0.
5 participants
Signed-off-by: Lizan Zhou [email protected]