feat: support listener/routes in post translate hook level

[Xunzhuo]

What type of PR is this?

feat: support listener/routes in post translate hook level

Which issue(s) this PR fixes:

Fixes #6523

Release Notes: Yes

[codecov]

Codecov Report

Attention: Patch coverage is 89.21569% with 11 lines in your changes missing coverage. Please review.

Project coverage is 71.09%. Comparing base (268aef8) to head (f7c4749).
Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
api/v1alpha1/envoygateway_helpers.go	58.33%	8 Missing and 2 partials ⚠️
internal/extension/registry/xds_hook.go	87.50%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6524      +/-   ##
==========================================
+ Coverage   71.05%   71.09%   +0.03%     
==========================================
  Files         220      220              
  Lines       37892    37965      +73     
==========================================
+ Hits        26926    26990      +64     
- Misses       9393     9399       +6     
- Partials     1573     1576       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[mathetake]

looks good to me but maybe leave a TODO about subsetting the resources (e.g. selecting clusters by labels etc) sent via PostTranslateModify since the request/response will be potentially a few mb-tens of mb ?

[Xunzhuo]

new approach has been tested in envoyproxy/ai-gateway@03573fd and it worked well.

enablePostTranslateListenersAndRoutes API looks like:

apiVersion: v1
kind: ConfigMap
metadata:
  name: envoy-gateway-config
  namespace: "envoy-gateway-system"
  labels:
    helm.sh/chart: gateway-helm-v0.0.0-latest
    app.kubernetes.io/name: gateway-helm
    app.kubernetes.io/instance: eg
    app.kubernetes.io/version: "latest"
    app.kubernetes.io/managed-by: Helm
data:
  envoy-gateway.yaml: |
    apiVersion: gateway.envoyproxy.io/v1alpha1
    kind: EnvoyGateway
    gateway:
      controllerName: gateway.envoyproxy.io/gatewayclass-controller
    logging:
      level:
        default: info
    provider:
      kubernetes:
        rateLimitDeployment:
          patch:
            type: StrategicMerge
            value:
              spec:
                template:
                  spec:
                    containers:
                    - imagePullPolicy: IfNotPresent
                      name: envoy-ratelimit
                      image: docker.io/envoyproxy/ratelimit:60d8e81b
      type: Kubernetes
    extensionApis:
      enableEnvoyPatchPolicy: true
      enableBackend: true
    extensionManager:
      backendResources:
        - group: inference.networking.x-k8s.io
          kind: InferencePool
          version: v1alpha2
      hooks:
        enablePostTranslateListenersAndRoutes: true
        xdsTranslator:
          post:
            - Translation
            - Cluster
            - Route
      service:
        fqdn:
          hostname: ai-gateway-controller.envoy-ai-gateway-system.svc.cluster.local
          port: 1063
    rateLimit:
      backend:
        type: Redis
        redis:
          url: redis.redis-system.svc.cluster.local:6379

[arkodg]

my preference would be to have something like

resource:
  listener:
    selector: {}

which selects all listeners, these key values are based on resource metadata

or some form with a selector, so we can only send specific resources

• should the top level be resource or translationHook ?

[arkodg]

wdyt @guydc

[Xunzhuo]

Created an issue for track: #6539

[Xunzhuo]

option1: make hook config explicitly set:

    extensionManager:
      backendResources:
        - group: inference.networking.x-k8s.io
          kind: InferencePool
          version: v1alpha2
      hooks:
        xdsTranslator:
          hookConfig:
            postTranslation:
              includeAll: false
              resources:
                listener: {}
                route: {}
                cluster: {}
                secret: {}
            postListener: {}
            postVirtualHost: {}
            postCluster: {}
            postRoute: {}              
          post:
            - Translation
            - Cluster
            - Route

option2: make hook config inline:

    extensionManager:
      backendResources:
        - group: inference.networking.x-k8s.io
          kind: InferencePool
          version: v1alpha2
      hooks:
        xdsTranslator:
          postTranslation:
            includeAll: false
            resources:
              listener: {}
              route: {}
              cluster: {}
              secret: {}
          postListener: {}
          postVirtualHost: {}
          postCluster: {}
          postRoute: {}              
          post:
            - Translation
            - Cluster
            - Route

option3: dont need hook config, just put resources under xdsTranslator:

    extensionManager:
      backendResources:
        - group: inference.networking.x-k8s.io
          kind: InferencePool
          version: v1alpha2
      hooks:
        xdsTranslator:
          includeAll: false
          resources:
            listener: {}
            route: {}
            cluster: {}
            secret: {}      
          post:
            - Translation
            - Cluster
            - Route

[arkodg]

thanks @Xunzhuo, prefer

       xdsTranslator:
          // translation hook setting common for pre and post, since its unlikely both will be set
          translation:
            includeAll: false

[Xunzhuo]

should add a stage in it? Like
stage: post
stage: pre

[arkodg]

should add a stage in it? Like stage: post stage: pre

yeah we could add that and extend it in the future, afaik most users are using post rn for xds hook

[Xunzhuo]

cc @arkodg a3f13e4

[arkodg]

LGTM thanks !

[guydc]

LGTM.
Thanks for adding this!

[Xunzhuo]

/retest