chore: fix make gen-check #7937
Open
+11
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cerulean-figolla-1f9435 canceled.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7937 +/- ##
==========================================
- Coverage 72.80% 72.78% -0.02%
==========================================
Files 237 237
Lines 35475 35475
==========================================
- Hits 25827 25821 -6
- Misses 7807 7812 +5
- Partials 1841 1842 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
arkodg
reviewed
Jan 14, 2026
tools/make/common.mk
Outdated
| @@ -128,7 +128,7 @@ export USAGE_OPTIONS | |||
|
|
|||
| .PHONY: generate | |||
| generate: ## Generate go code from templates and tags | |||
| generate: kube-generate docs-api helm-generate go.generate kube-generate-examples | |||
| generate: kube-generate docs-api go.generate kube-generate-examples | |||
Contributor
There was a problem hiding this comment.
doesnt this make generate ?
Member
Author
There was a problem hiding this comment.
maybe we should move helm template out of helm-generate
zirain
force-pushed
the
chore-gen-check
branch
3 times, most recently
from
e244a79 to
f9c2997
Compare
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
zirain
force-pushed
the
chore-gen-check
branch
from
960888a to
9ec0654
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
helm templatefromhelm-genreatehelm-templatepart of thegen-checkbut aftermanifest