feat (translator): support optional health check configuration #7959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cryoshida
force-pushed
the
health-check-overwrites
branch
4 times, most recently
from
1dd6dcf to
aa8c906
Compare
nareddyt
approved these changes
Jan 14, 2026
Contributor
nareddyt
left a comment
nareddyt
left a comment
There was a problem hiding this comment.
Looks great! I am not familiar with e2e test setup, but all other files LGTM
internal/ir/xds.go
Outdated
|
|
||
| // Validate the fields within the HealthCheckOverrides structure. | ||
| func (h *HealthCheckOverrides) Validate() error { | ||
| if h.Port > 65535 { |
Contributor
There was a problem hiding this comment.
0 should be considered invalid as well, it is typically reserved for bind() calls
Author
There was a problem hiding this comment.
Updated in a separate commit!
cryoshida
force-pushed
the
health-check-overwrites
branch
from
aa8c906 to
20752b9
Compare
Signed-off-by: Rinka Yoshida <[email protected]>
Signed-off-by: Rinka Yoshida <[email protected]>
cryoshida
force-pushed
the
health-check-overwrites
branch
from
20752b9 to
cfb1c2a
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7959 +/- ##
==========================================
+ Coverage 72.80% 72.85% +0.05%
==========================================
Files 235 235
Lines 35313 35335 +22
==========================================
+ Hits 25709 25744 +35
+ Misses 7781 7772 -9
+ Partials 1823 1819 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Release Notes: Yes/No