feat(telemetry): add resourceAttributes to OTLP backends#7972
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 canceled.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7972 +/- ##
==========================================
+ Coverage 73.65% 73.69% +0.03%
==========================================
Files 239 240 +1
Lines 36311 36333 +22
==========================================
+ Hits 26745 26775 +30
+ Misses 7671 7662 -9
- Partials 1895 1896 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@codefromthecrypt can you see any docs in |
|
Thanks, so definitely seems to be an issue with the fields... Nothing obvious jumps out. If you're able to grab an OTLP dump (OTLP/JSON is fine if easier to drop here) then I can try to reproduce and see what's up (probably on Monday). |
89fed9e to
1eeb986
Compare
|
@zhaohuabing or anyone else can you please merge this? getting really close to otel working. aigw is still using console logs as this is missing and until it is there it won't be able to switch effectively as otel without consistent resource attrs isn't really useful. envoyproxy/ai-gateway#1808 |
| ReportCountersAsDeltas: sink.ReportCountersAsDeltas, | ||
| ReportHistogramsAsDeltas: sink.ReportHistogramsAsDeltas, | ||
| Headers: sink.Headers, | ||
| Resources: sink.Resources, |
There was a problem hiding this comment.
is a similar change needed for k8s ?
There was a problem hiding this comment.
next commit should fix that. thanks!
7f25d98 to
889b59a
Compare
|
@codefromthecrypt can you fix the conflict? |
acc6be1 to
d7e3b4a
Compare
fa345d2 to
0a36a8d
Compare
0a36a8d to
447a0f5
Compare
|
@zhaohuabing @arkodg @zirain I deprecated the resources -> resourceAttributes in logs then made the two new ones resourceAttributes re-built and ran through the demo and updated the screen shots which show it works. PTAL 🤞 |
447a0f5 to
e5b7349
Compare
|
Added support for: - Custom headers on OTLP exports (metrics, tracing, access logs) - Resource attributes on OTLP metrics and tracing sinks via the resources field - TLS telemetry gRPC backends Signed-off-by: Adrian Cole <[email protected]>
Signed-off-by: Adrian Cole <[email protected]>
Signed-off-by: Adrian Cole <[email protected]>
f2b32a0
e5b7349 to
f2b32a0
Compare
|
rebased |
|
/retest |
1 similar comment
|
/retest |
…7972) Signed-off-by: Sadmi Bouhafs <[email protected]>
What type of PR is this?
feat(telemetry): add new feature
What this PR does / why we need it:
Adds support for resource attributes on OTLP metrics and tracing sinks, enabling callers like Envoy AI Gateway to map all attributes required for Elastic Cloud OTLP endpoints.
This completes the
OTEL_RESOURCE_ATTRIBUTESequivalent for all three OTLP signals:resourcesfield in favor ofresourceAttributes(maps to Envoy'sresource_attributes)resourceAttributesfield (maps to Envoy'sresource_detectorswithStaticConfigResourceDetector)resourceAttributesfield (maps to Envoy'sresource_detectorswithStaticConfigResourceDetector)Example use case: Setting
service.name,service.version, anddeployment.environmentfor proper service identification in observability backends like Elastic APM.otel-tui



Release Notes: Yes