Skip to content

Conversation

@jukie
Copy link
Contributor

@jukie jukie commented Jan 17, 2026

What this PR does / why we need it:
Adds the ability to configure SchemeHeaderTransformation inside ClientTrafficPolicy

Which issue(s) this PR fixes:

Fixes #7979

Release Notes: Yes

I validate that this change makes it possible to run a gRPC .NET service with gateway TLS termination

@netlify
Copy link

netlify bot commented Jan 17, 2026

Deploy Preview for cerulean-figolla-1f9435 canceled.

Name Link
🔨 Latest commit d00a3c7
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/696b28967d454c00081b26f1

@codecov
Copy link

codecov bot commented Jan 17, 2026

Codecov Report

❌ Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.82%. Comparing base (d0f72f6) to head (d00a3c7).

Files with missing lines Patch % Lines
internal/xds/translator/listener.go 86.66% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7980   +/-   ##
=======================================
  Coverage   72.82%   72.82%           
=======================================
  Files         237      237           
  Lines       35475    35495   +20     
=======================================
+ Hits        25835    25851   +16     
- Misses       7801     7805    +4     
  Partials     1839     1839           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jukie jukie changed the title Add SchemeHeaderTransformation feat: Add SchemeHeaderTransformation to ClientTrafficPolicy Jan 17, 2026
@jukie jukie requested a review from a team January 17, 2026 02:49
@jukie jukie marked this pull request as ready for review January 17, 2026 02:49
@jukie jukie requested a review from a team as a code owner January 17, 2026 02:49
@jukie
Copy link
Contributor Author

jukie commented Jan 17, 2026

/retest

@arkodg
Copy link
Contributor

arkodg commented Jan 17, 2026

@jukie this is same as #7842 but does it in CTP because its a HCM setting ?

@jukie
Copy link
Contributor Author

jukie commented Jan 17, 2026

Nice I hadn't seen that! I even reviewed it 🤦.

Yeah it's the same and I can close mine in favor of it but that one is missing the explicit override field.

@jukie
Copy link
Contributor Author

jukie commented Jan 17, 2026

Correction, this is a listener level setting so adding to BTP isn't right.

@arkodg
Copy link
Contributor

arkodg commented Jan 17, 2026

Correction, this is a listener level setting so adding to BTP isn't right.

yeah can we highlight this in the other issue, and steer it in the right direction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.NET servers reject https gRPC requests terminated to plaintext by Envoy

2 participants