-
Notifications
You must be signed in to change notification settings - Fork 647
feat: Ignore ready and stats listener metrics in shutdown manager calculation #7985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 canceled.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7985 +/- ##
==========================================
+ Coverage 72.86% 72.92% +0.05%
==========================================
Files 237 237
Lines 35536 35550 +14
==========================================
+ Hits 25894 25925 +31
+ Misses 7801 7782 -19
- Partials 1841 1843 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…culation Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
| } else { | ||
| defer resp.Body.Close() | ||
| } | ||
| defer func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can there be a case where resp is nil
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK, resp shouldn't be nil when there's no error.
fixes: #7947
use
listener.(.*).downstream_cx_activestats instead ofserver.total_connectionswhich contains ready and stats listener.