Skip to content

Conversation

@zirain
Copy link
Member

@zirain zirain commented Jan 19, 2026

fixes: #7947

use listener.(.*).downstream_cx_active stats instead of server.total_connections which contains ready and stats listener.

@zirain zirain requested a review from a team as a code owner January 19, 2026 04:37
@netlify
Copy link

netlify bot commented Jan 19, 2026

Deploy Preview for cerulean-figolla-1f9435 canceled.

Name Link
🔨 Latest commit 724b789
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/696ed06170724e0008d0e13e

@zirain zirain changed the title feat: Ignore ready and stats listener metrics in shutdown manager cal… feat: Ignore ready and stats listener metrics in shutdown manager calculation Jan 19, 2026
@codecov
Copy link

codecov bot commented Jan 19, 2026

Codecov Report

❌ Patch coverage is 63.41463% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.92%. Comparing base (a8952d0) to head (724b789).

Files with missing lines Patch % Lines
internal/cmd/envoy/shutdown_manager.go 63.41% 12 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7985      +/-   ##
==========================================
+ Coverage   72.86%   72.92%   +0.05%     
==========================================
  Files         237      237              
  Lines       35536    35550      +14     
==========================================
+ Hits        25894    25925      +31     
+ Misses       7801     7782      -19     
- Partials     1841     1843       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

} else {
defer resp.Body.Close()
}
defer func() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can there be a case where resp is nil

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, resp shouldn't be nil when there's no error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ignore ready and stats listener metrics in shutdown manager calculation

2 participants