-
Notifications
You must be signed in to change notification settings - Fork 1
Add GPU based sample laser sensor to simulate Livox mid360 sensor #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
acd1bd3 to
46e8cff
Compare
46e8cff to
3bf0de5
Compare
c13139a to
db399bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it make sense to make it a general option to disable the intensity configuration? The motivation is purely performance related right?
Maybe it would also be beneficial for other (non-sample) sensors if this could be disabled and we save a lot of computation (time). I think we don't use the intensities much, if we even use them anywhere at all...
|
Should we drop the existing commits concerning the cubemap implementation from |
43bcca0 to
9b60f09
Compare
True, I added a parameter |
instead of rotate the camera back and forth.
disable compute_intensity to save some performance. If it is disabled, the intensity is set to the fixed value automatically
9b60f09 to
da5ab06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it again and looks good!
|
Because of the merging conflicts, from updating the commits to the newest version 11.2.0 from the upstream gazebo-classic repo, I will push the gazebo11 PR branch manually to |
This PR adds the following:
My changes:
laserscan_angles, which extends the typelaserscanwith theazimuthandzenithanglessample_sensorto truesample_sizeto define the amount of "samples", which are published using the angles in the csv files for each stepsample_csv_fileto a csv file with the angles for the sample sensorHow-To-Test: