Skip to content

Refactor: Apply Interface Segregation Principle to SMS drivers and contracts #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Refactor: Apply Interface Segregation Principle to SMS drivers and contracts #3

wants to merge 2 commits into from

Conversation

mrabbani
Copy link
Member

This PR refactors the SMS package to properly follow the Interface Segregation Principle.

  • Only drivers that require getClient() implement ClientInterface.
  • All drivers implement SmsContract.
  • DriverManager and type hints now use SmsContract.
  • Log and AlphaBd drivers no longer have unnecessary getClient() methods.

This improves code clarity and maintainability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mrabbani