fix: p2p connect #145
fix: p2p connect #145
Conversation
merge pull request
new handshake signature: inner signature structure must be present WriteP2PMessage error should return
maoueh
left a comment
maoueh
left a comment
There was a problem hiding this comment.
About the signature data change, the other one, I'll probably merge right away.
| byte(ecc.CurveK1), | ||
| } | ||
| data = append(data, make([]byte, 65, 65)...) | ||
| signature, err := ecc.NewSignatureFromData(data) |
There was a problem hiding this comment.
The NewSignatureFromData(data) does this internally:
signature := Signature{
Curve: CurveID(data[0]), // 1 byte
Content: data[1:], // 65 bytes for K1 and R1, variable length for WA
}
Which is equivalent to the previous as far as I can tell. So what is being fixed here exactly? I'm not sure I follow.
There was a problem hiding this comment.
Which is equivalent to the previous as far as I can tell. So what is being fixed here exactly? I'm not sure I follow.
@maoueh Curve is copied to Content, without this fix I'm getting an error
unable to encode message handshake ...... invalid signature: the inner signature structure must be present, was nil
The problem is either here or in the encoder I guess
| err = p.WriteP2PMessage(handshake) | ||
| if err != nil { | ||
| err = errors.Wrapf(err, "sending handshake to %s", p.Address) | ||
| return errors.Wrapf(err, "sending handshake to %s", p.Address) |
There was a problem hiding this comment.
Definitely mergeable right away.
|
Hi, sadly It's still relevant. Any news? |
|
@angrypie Sorry I missed your previous message in the commit/pr directly. I still don't get the differences. What is the easier to reproduce for me, should a unit test exhibits the problem from your perspective? |
|
@maoueh Check an error on this line /cmd/eos-p2p-client/main.go:40 |
3 participants
fix p2p connect no return error.
handshake signature should have inner signature structure.