Modify the function of SignCanonical in btcec, do makeCompact after isCanonicalSig. #218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sCanonicalSig. Since function recoverKeyFromSignature is called inside function makeCompact, the performance loss calculated by function recoverKeyFromSignature is relatively large. So do makeCompact after isCanonicalSig can reduce the number of times it is executed, when isCanonicalSig is false then continue the next loop. The average performance improvement after modification is nearly 40%－50%.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since function recoverKeyFromSignature is called inside function makeCompact, the performance loss calculated by function recoverKeyFromSignature is relatively large. So do makeCompact after isCanonicalSig can reduce the number of times it is executed, when isCanonicalSig is false then continue the next loop. The average performance improvement after modification is nearly 40%－50%.