-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize Various Functions and Refactor #4
base: master
Are you sure you want to change the base?
Conversation
utilize vectorized operations from numpy when calculating margins matrix, as opposed to a nested for loop
I added in the tests with 986a806, and the following is the output (running
BFS and DFS now have similar performance. I also reverted by |
It seems as though on large amounts of ballots, as in ba56f14, the difference between DFS and BFS is much clearer, and the bi-directional BFS is outperforming DFS. |
Finally, the tests for the improved models in b25eceb. All 3 perform better than their old counterparts. |
black
.core
by using vectorized operations as opposed to the previous nested for loop.I'll try and get some benchmarks to see how much of a performance improvement there is.